Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace uses of unix-compat with unix to fix builds on GHC 9.4+ #216

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Replace uses of unix-compat with unix to fix builds on GHC 9.4+ #216

wants to merge 2 commits into from

Conversation

faezs
Copy link

@faezs faezs commented Sep 17, 2023

@vkleen
Copy link
Contributor

vkleen commented Sep 18, 2023

If I understand correctly, funflow will fail to build with new versions of unix-compat because the latter removed Sytem.PosixCompat.User which our Docker support is using. But the latter has always returned dummy data anyways, so this change shouldn't make things worse?

@faezs
Copy link
Author

faezs commented Sep 18, 2023

That's my understanding from perusing related issues too. The build failure appears to be unrelated to the changes though

@vkleen vkleen mentioned this pull request Sep 19, 2023
Merged
@justjoheinz justjoheinz mentioned this pull request Jul 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@faezs @vkleen