Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed bootstrap-4 from footer #40934

Closed

Conversation

AKSHAY-CHOWDARY
Copy link

Description

Removed boostrap-4 from footer #40923

Motivation & Context

Now that it's been nearly 2 years since Bootstrap v4 went EOL I think it makes sense to remove that link as having it there may indirectly wrongly give the impression that it's supported and/or recommended in some way.

Removing this link may help reduce page rank of Bootstrap v4 pages in search engines and prioritize v5 too :-) (searching for bootstrap carousel in Google for me still shows the v4.0 docs as the top result

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@julien-deramond
Copy link
Member

Thanks @AKSHAY-CHOWDARY but there's already a PR for that, see #40924

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants