Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Remove Bootstrap 4 link from footer #40924

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Docs: Remove Bootstrap 4 link from footer #40924

wants to merge 1 commit into from

Conversation

coliff
Copy link
Contributor

@coliff coliff commented Oct 9, 2024 •
edited
Loading

Description & Motivation & Context

Bootstrap 4 is EOL, so remove the link.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Fixes: #40923

@coliff
Remove Bootstrap 4 link from footer
cfac0f0 
Bootstrap 4 is EOL, so remove the link.
Fixes: twbs#40923
julien-deramond
julien-deramond approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm down for it, since the v4-dev branch is no longer relevant. We're not planning any further updates as it's now EOL. What do you think, core team?

@coliff coliff changed the title Remove Bootstrap 4 link from footer Docs: Remove Bootstrap 4 link from footer Oct 9, 2024
@louismaximepiton
Copy link
Member

I'm fine with deleting this.

This was referenced Oct 11, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-deramond julien-deramond julien-deramond approved these changes

@mdo mdo Awaiting requested review from mdo

@XhmikosR XhmikosR Awaiting requested review from XhmikosR

Assignees
No one assigned
Labels
docs enhancement v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Suggestion - remove Bootstrap 4 from footer
3 participants
@coliff @louismaximepiton @julien-deramond