-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropdown: Allow cycling inside #38828
base: main
Are you sure you want to change the base?
Conversation
👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this change, and think it would be good to have it as a default. potentially with an option to opt out?
Accessibility by default, I like that :) |
Description
Add cycling for the dropdown menu using arrow up and arrown down. I wonder if this should be deactivated by default and activated by an option or not (feels weird using it on a nested dropdown for example) 🤔 Or if, as it's an option, we shouldn't add it at all ?
Motivation & Context
It is mentionned by https://www.w3.org/WAI/ARIA/apg/patterns/menubar/ as optional.
Couldn't find any information in older PRs.
Type of changes
Checklist
npm run lint
)Live previews
Related issues
Closes #38801.