Closed
Conversation
- Adds .rounded-1, .rounded-2, and .rounded-3 - Drops .rounded-sm and .rounded-lg because they conflict with breakpoint nomenclature - Rearrange rounded docs
| $border-radius-sm: .2rem !default; | ||
| $border-radius-lg: .3rem !default; | ||
|
|
||
| $rounded-sizes: map-remove($spacers, 4, 5) !default; |
Member
There was a problem hiding this comment.
I think we better redelare the sizes here, would be weird if the spacers map is changed to :
$spacers: (
0: 0,
1: $spacer / 4,
2: $spacer / 2,
3: $spacer,
4: $spacer * 1.5,
5: $spacer * 3,
6: $spacer * 4.5,
) !default;
Member
Author
|
Replaced by #31687 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30048, fixes #29989, closes #30778.
My hope with this PR is to balance keeping the primary
.roundedclass while reducing confusion around class names and adding additional control. To that end, I'm thinking of keeping.roundedeven though it's the same as.rounded-1as of right now. This then drops.rounded-smand.rounded-lgfor something else.That last change feels maybe problematic though since our large and small inputs and buttons use those variables.
Which of the referenced PRs are the best approaches? I feel like I could go any direction...
/cc @twbs/css-review