Skip to content

v5: Utilities CSS cleanup, new border and bg utils, renames rounded to radius#30778

Closed
mdo wants to merge 4 commits intomainfrom
v5-utils-cleanup
Closed

v5: Utilities CSS cleanup, new border and bg utils, renames rounded to radius#30778
mdo wants to merge 4 commits intomainfrom
v5-utils-cleanup

Conversation

@mdo
Copy link
Copy Markdown
Member

@mdo mdo commented May 11, 2020

@mdo mdo requested a review from a team as a code owner May 11, 2020 22:29
@mdo mdo changed the title v5: Utilities CSS cleanup, new border and bg utils v5: Utilities CSS cleanup, new border and bg utils, renames rounded to radius May 11, 2020
@alecpl
Copy link
Copy Markdown
Contributor

alecpl commented May 12, 2020

I kinda prefer the long suffixes (-left, -right, -top, -bottom). I see from where the short version comes from, but.... radius-1 (one) and radius-l (left) looks almost the same, which might be confusing.

I propose to use rl, rr, rb, rt. Also, adding x and yvariants and all 6 size specifiers would make sense. Also, make the size specifier required (so no radius, but r-1). It would unify radius tool with spacing utilities.

@alecpl
Copy link
Copy Markdown
Contributor

alecpl commented May 12, 2020

After writing above comment I realized that most utilities do not use abbreviations. So, it would make more sense if spacing utilities would use whole words (padding, margin, top, left, etc.) too. Rather than changing radius to r

mdo added 4 commits May 13, 2020 11:58
- bg-gray is new and maps to gray-400
- border-gray-500 and border-gray-700 are new and are meant to complement bg-gray and bg-secondary as one level off from the borders
@mdo mdo force-pushed the v5-utils-cleanup branch 2 times, most recently from 94c6648 to 33b04a1 Compare May 14, 2020 01:21
@MartijnCuppens
Copy link
Copy Markdown
Member

Feels weird to have numbers in the border utilities, but not in the bg colors. Not sure how we could improve that though.

@mdo
Copy link
Copy Markdown
Member Author

mdo commented May 14, 2020

Feels weird to have numbers in the border utilities, but not in the bg colors. Not sure how we could improve that though.

Agreed... will think on it more.

@mdo mdo changed the base branch from master to main June 16, 2020 19:56
@mdo mdo mentioned this pull request Jun 19, 2020
@mdo
Copy link
Copy Markdown
Member Author

mdo commented Sep 17, 2020

Closing as it's full of conflicts.

@mdo mdo closed this Sep 17, 2020
@mdo mdo deleted the v5-utils-cleanup branch September 17, 2020 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Confusing classes rounded-sm and rounded-lg

3 participants