Simplify checkbox & radio input #30557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Define background properties in `.form-check-input` - Use `background-size: contain` to simplify background sizes (especially for those with linear gradients) - Remove double `color-adjust` - Adjust svgs to 20x20 box. This way the strokes aren't rescaled.
Member
Author
|
Ping @twbs/css-review for review |
ffoodd
approved these changes
Apr 14, 2020
Member
ffoodd
left a comment
ffoodd
left a comment
There was a problem hiding this comment.
LGTM. Being curious again, is there a reason not to use background shorthand here? Seems pretty safe in that case, isn't it?
Member
Author
|
We try to live with the rule: Only use shorthand properties if all properties are covered. Another thing, someone might have configured something like I also once came across an issue where someone used custom properties, similar to the Also, I do prefer clarity over a negligible improvement in filesize |
Member
That's a good one :) |
Member
|
Missed this entirely, nice! |
olsza
pushed a commit
to olsza/bootstrap
that referenced
this pull request
Oct 3, 2020
- Define background properties in `.form-check-input` - Use `background-size: contain` to simplify background sizes (especially for those with linear gradients) - Remove double `color-adjust` - Adjust svgs to 20x20 box. This way the strokes aren't rescaled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the checkboxes a bit. A lot of properties are very unlikely to change, like
background-positionorbackground-repeat, so I think it's better to remove them from the variables file to keep things clear..form-check-inputbackground-size: containto simplify background sizes (especially for those with linear gradients)color-adjustAlso tested this with the gradients enabled.
Fixes #30528 (comment)
Demo: https://deploy-preview-30557--twbs-bootstrap.netlify.com/docs/4.3/forms/checks/