Add checkbox transition #30528
Merged
Add checkbox transition #30528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdo
reviewed
Apr 7, 2020
Member
mdo
left a comment
mdo
left a comment
There was a problem hiding this comment.
Would we ever consider splitting the transition variables out to reduce repetition?
$form-check-transition-duration: .15s !default;
$form-check-transition-timing: ease-in-out !default;
$form-check-transition-property: background-color, background-position, opacity !default;
Member
Author
Yup, that might be a lot clearer. I sticked to this way to be consistent with the buttons and inputs. I think we better tackle this in another PR, and have a look at the benefits/disadvantages there. |
ysds
approved these changes
Apr 8, 2020
mdo
approved these changes
Apr 9, 2020
|
Side affect: Now when a change occurs, like a checkbox being checked or a radio choice being changed, during the transition, the box/radio slightly shifts (from an offset position) down and to the right to be in the correct, centered position. |
olsza
pushed a commit
to olsza/bootstrap
that referenced
this pull request
Oct 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30526. Transitioning the
background-positionfor the switch ain't ideal, but since it's such a small element, I don't expect any dramatic performance downsides.