Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix <legend> wrapping bug #30345

Merged
merged 1 commit into from
Mar 21, 2020
Merged

Fix <legend> wrapping bug #30345

merged 1 commit into from
Mar 21, 2020

Conversation

MartijnCuppens
Copy link
Member

Fixes #29712. Alternative for #29831 which works in Edge.

@MartijnCuppens MartijnCuppens requested a review from a team as a code owner March 6, 2020 12:49
@MartijnCuppens MartijnCuppens changed the title Fix wrapping bug Fix <legend> wrapping bug Mar 6, 2020
@ysds
Copy link
Member

ysds commented Mar 8, 2020

What is a reason not to use display: table like normalize.css?

@mdo
Copy link
Member

mdo commented Mar 10, 2020

Might be imagining it, but I feel like we ran into an issue with the table approach? Can't remember...

@MartijnCuppens
Copy link
Member Author

MartijnCuppens commented Mar 10, 2020 •
edited
Loading

The reason is ease of theming:
v4: https://codepen.io/MartijnCuppens/pen/vYOdBeo (border issue)
v5: https://codepen.io/MartijnCuppens/pen/VwLQZWN

@XhmikosR
Copy link
Member

@MartijnCuppens can you rebase this please?

@XhmikosR XhmikosR merged commit c51e9fa into master Mar 21, 2020
@XhmikosR XhmikosR deleted the master-mc-legend-fix branch March 21, 2020 14:44
ashfahan added a commit to fluid-framework/Fluid that referenced this pull request Apr 23, 2020
@ashfahan
🆙 📦 Updates from bootstrap reboot
a7bdca7 
twbs/bootstrap#30323
twbs/bootstrap#30340
twbs/bootstrap#30345
twbs/bootstrap#30353
twbs/bootstrap#30269
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
@MartijnCuppens @olsza
Fix wrapping bug (twbs#30345)
7347f6b
@mdo mdo mentioned this pull request Dec 22, 2020
Closed
@davekaro davekaro mentioned this pull request Jun 23, 2021
Merged
@WOLFRIEND WOLFRIEND mentioned this pull request Dec 15, 2023
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

Assignees
No one assigned
Labels
css no-backport-to-v4 v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flex container doesn't display correctly next to a legend
4 participants
@MartijnCuppens @ysds @mdo @XhmikosR