Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reboot file: adds some grouping and comments standardizations #30340

Merged
merged 7 commits into from
Mar 5, 2020
Merged

reboot file: adds some grouping and comments standardizations #30340

merged 7 commits into from
Mar 5, 2020

Conversation

zalog
Copy link
Contributor

@zalog zalog commented Mar 5, 2020

This PR:

  • groups sections by html elements, and adds two nl before each
  • labels sections where needed
  • adds some comment consistency
  • sticks "credits" and "see" with description / it helps if we number that
  • removes not needed spaces
  • adds or remove numbers where needed

I had to rewrite this in a project, so I had some time for this minor details :).

Thanks for your review time.

@zalog zalog requested a review from a team as a code owner March 5, 2020 10:51
@ysds ysds added the css label Mar 5, 2020
@ysds ysds requested a review from MartijnCuppens March 5, 2020 12:08
MartijnCuppens
MartijnCuppens approved these changes Mar 5, 2020
View reviewed changes
Copy link
Member

@MartijnCuppens MartijnCuppens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better, thanks!

@ysds ysds merged commit 59c5d75 into twbs:master Mar 5, 2020
@zalog zalog deleted the zalog-reboot-docs branch April 17, 2020 16:40
ashfahan added a commit to fluid-framework/Fluid that referenced this pull request Apr 23, 2020
@ashfahan
🆙 📦 Updates from bootstrap reboot
a7bdca7 
twbs/bootstrap#30323
twbs/bootstrap#30340
twbs/bootstrap#30345
twbs/bootstrap#30353
twbs/bootstrap#30269
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
@ysds @olsza
reboot file: adds some grouping and comments standardizations (twbs#3…
698d541 
…0340)

* style: groups sections

- adds two nl before any section
- extract elements from wrong section ex: `mark` from `form`

* style: format comments

* style: sticks all `see`s with the description

- sticks
- renames

* style: removes not needed spaces

* style: removes not needed number like other cases

* style: stick credits with description

* style: adds missing number
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartijnCuppens MartijnCuppens MartijnCuppens approved these changes

Assignees
No one assigned
Labels
css no-backport-to-v4 v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zalog @MartijnCuppens @ysds