fix(EAV-640): make current segment timing consider partInstances #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor(EAV-450): get rid of async in handlers; extract shared logic
feat(EAV-487): add buckets topic to LSG
feat(EAV-296): implement tally for device trigger previews
feat(EAV-488): add packages topic to LSG
feat(EAV-111): add current segment parts to LSG
fix(EAV-450): missing null activePlaylist update when playlist gets deactivated
…lications it is not needed for the UI nor any other ddp subscriber
fix(EAV-514): omit privateData in bucket adlib pieces and actions pub…
… the following Part(s) (#46) problem was in the rank initially set to a placeholder 99999 recalculated too late, it was confusing the code that finds infinites from pieces in parts preceding the inserted one
this is a hack that makes lookaheads work until superfly-timeline is fixed
chore(EAV-526): update TSR and superfly-timeline
Sync release52
fix(EAV-534): duration of pieces with 'now' start time
it was broken by introduction of `motion` in Sofie-Automation#1400
fix(EAV-555): make prompter scroll
chore(EAV-539): sync release52 and update TSR
an array of keyIndex:actionId can be provided in shuttleWebHid_buttonMap
properties not present in apiStudio needed to be taken from the existing studio
… not generate invalid overrides, and correctly preserve existing overrides
chore(EAV-599): update TSR
feat(EAV-372): allow mic muting
chandrashekar-nallamilli
force-pushed
the
release53
branch
4 times, most recently
from
4df992a to
25fb026
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port EAV-640 fix from release52 to release53
Changes:
calculateSegmentTimingto consider partInstancesWhy needed:
The upstream function signature does not include
segmentPartInstancesparameter. This fix ensures LSG shows accurate segment timings when parts have been modified by adLib actions.Upstream status: TV2-internal LSG enhancement, not in upstream
Brings release53 to feature parity with release52.