Skip to content

Conversation

@jstarpl
Copy link
Contributor

@jstarpl jstarpl commented Mar 10, 2025

About the Contributor

This pull request is posted on behalf of the NRK.

Type of Contribution

This is a:

Bug fix / Dependency update

Current Behavior

Release 52 still uses a deprecated library called velocity and it's React wrapper, causing lots of errors to be printed to the console.log and eventually to Sofie Core system log as a client error report.

New Behavior

velocity is replaced by motion in some places, and replaced with regular CSS transitions and animations where possible.

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

This PR affects the GUI looks and functionality in various locations (Rundown View, Countdown view, Prompter)

Time Frame

We intend to finish the development on this feature in a week.

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@jstarpl jstarpl requested a review from a team as a code owner March 10, 2025 10:02
@codecov
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.26%. Comparing base (33514b1) to head (8c5dd70).
Report is 83 commits behind head on release52.

Additional details and impacted files
@@              Coverage Diff              @@
##           release52    #1400      +/-   ##
=============================================
- Coverage      56.38%   56.26%   -0.13%     
=============================================
  Files            406      408       +2     
  Lines          72655    73125     +470     
  Branches        4602     4222     -380     
=============================================
+ Hits           40967    41141     +174     
- Misses         31469    31746     +277     
- Partials         219      238      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jstarpl jstarpl changed the title fix(Dependencies): remove velocity React (SOFIE-3716) fix(dependencies): remove velocity React (SOFIE-3716) Mar 10, 2025
@jstarpl jstarpl added the 🐛🔨 bugfix This is a fix for an issue label Mar 20, 2025
@jstarpl jstarpl merged commit 41c56d2 into release52 Mar 27, 2025
66 of 67 checks passed
@jstarpl jstarpl deleted the fix/remove-velocity-react/sofie-3716 branch March 27, 2025 15:38
@Julusian Julusian mentioned this pull request Apr 15, 2025
7 tasks
ianshade added a commit to tv2norge-collab/sofie-core that referenced this pull request Apr 16, 2025
it was broken by introduction of `motion` in Sofie-Automation#1400
ianshade added a commit to tv2norge-collab/sofie-core that referenced this pull request Apr 16, 2025
it was broken by introduction of `motion` in Sofie-Automation#1400
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛🔨 bugfix This is a fix for an issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants