Post interaction button size pop

[tunjid]

Supercedes #811

[gemini-code-assist]

Summary of Changes

Hello @tunjid, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the user interface for post interaction buttons within the timeline, focusing on visual feedback and responsiveness. It introduces new animations for button presses and state changes, along with an optimistic UI update mechanism for certain interactions. The changes aim to make the interaction experience more engaging and immediate for users.

Highlights

• Enhanced Button Animations: Implemented a 'pop' animation for interactive buttons (Like, Bookmark) and smooth fade/slide transitions for icons and associated text, providing a more dynamic user experience.
• Optimistic UI Updates: Introduced an 'opportunistic' state for buttons like 'Like' and 'Bookmark' to provide immediate visual feedback to the user upon interaction, improving perceived responsiveness before the backend state is fully updated.
• Refactored Interaction Composables: Consolidated animation and state management logic into new PostInteractionElements and a PostInteractionButton.Status sealed class, making the PostInteraction composable cleaner, more modular, and reusable.
• Increased Icon Size: Slightly increased the icon size for post interaction buttons in the Text.WithEmbed presentation mode from 16.dp to 18.dp for better visibility.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the post interaction buttons to introduce new animations, including a 'pop' effect for certain actions like 'like' and 'bookmark'. The changes centralize button-specific logic and use AnimatedContent for smoother transitions. While the refactoring and animation additions are a great improvement, there are a couple of critical logical errors in the implementation of the optimistic UI updates. The status of the interaction is not being correctly identified as 'opportunistic', and the state toggling on click is flawed. I've left specific comments with suggestions to fix these issues.

[tunjid]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces a 'pop' animation for interaction buttons and implements optimistic UI updates, which significantly enhances the user experience. The code is well-refactored, centralizing button configurations and animation logic effectively. I've identified one high-severity issue where rapid clicks can dispatch multiple actions, and have provided a code suggestion to rectify this. Overall, this is a great enhancement.

[tunjid]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces a sophisticated animation and optimistic update mechanism for post interaction buttons. The changes are well-structured, using sealed classes for state management (PostInteractionButton.Status) and extension properties on PostInteractionButton to declaratively configure behavior for different button types. The use of AnimatedContent for icons and text, combined with graphicsLayer for scaling animations, results in a polished user experience. The refactoring of PostInteraction and PostInteractionElements successfully encapsulates the complex UI logic, making the code more modular and maintainable. Overall, this is an excellent enhancement to the UI.