post interaction button changes (re-up)

[ThatOneCalculator]

Re-up of #809 just for the button size & pop

Before	After

[gemini-code-assist]

Summary of Changes

Hello @ThatOneCalculator, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining the user experience for post interaction buttons by introducing both visual and haptic feedback. It adds a subtle 'pop' animation and haptic feedback when users like or bookmark a post, ensuring a more engaging and responsive interaction. Additionally, it implements smooth transitions for the icons of these buttons and makes a minor adjustment to their size in specific display contexts.

Highlights

• Enhanced Interaction Feedback: Implemented a 'pop' animation for interaction buttons (Like, Bookmark) when their state changes, providing a more dynamic visual response.
• Haptic Feedback Integration: Added haptic feedback (long press vibration) for 'Like' and 'Bookmark' button presses, improving the tactile user experience.
• Smooth Icon Transitions: Utilized Crossfade to enable smooth visual transitions between the outlined and filled states of the 'Like' and 'Bookmark' icons.
• Icon Size Adjustment: Slightly increased the size of action icons from 16.dp to 18.dp for posts displayed in the Text.WithEmbed presentation mode.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a 'pop' animation and haptic feedback for interaction buttons like 'Like' and 'Bookmark', and adjusts icon sizes. The changes are well-contained and improve the user experience by providing clear visual feedback. My review includes suggestions to simplify the animation logic, improve code readability by removing magic numbers, and refine the use of haptic feedback to better align with platform conventions. Overall, a nice enhancement to the UI.

[tunjid]

There are some small perf things I'll fix on top of your commits.

[ThatOneCalculator]

Ty! I'm sure that I'm missing a lot of best practices, I've never done any meaningful work in Jetpack Compose until now.

[tunjid]

Sorry still reviewing this. One of the reasons animating this has been put off for so long is that the architecture of the app is offline first and the database is always the source of truth. So changes to isChecked always has a bit of a delay while the round trip to network and back are pending.

When the app is offline, the anim is really delayed and looks off. The Bluesky post about assuming opportunistic writes would be nice, but then I have to manage state about what the expected value and the actual value are. So each tap has an expected value where the db should eventually catch up to. In the case the app is offline, this won't happen anytime soon and I need to have a sort of intermediate state showing the like (or bookmark, repost, etc) is pending. This is why I wanted to use lottie so I could play an animation loop till the action is confirmed.

[ThatOneCalculator]

I don't think that the pop animation looping would look good, imo it should either be:

• Color change plays immediately, loading animation plays if >500ms to like, then pop animation when it goes through
• Color changes plays & haptic immediately on button push, then pop animation when it goes through (I prefer this one)

[tunjid]

Superceded by the PR above. Closing.