feat: Handle references for exception sets in Synchronized Groups#1014
Merged
pepicrft merged 3 commits intotuist:mainfrom Dec 19, 2025
Merged
Conversation
Generate permanent references for PBXFileSystemSynchronizedExceptionSet objects, including build file and build phase exception sets. Updates tests to verify that references for exception sets are correctly converted to permanent values.
Contributor
Author
|
@fortmarek @yonaskolb @pepicrft can someone please help with reviewing this? I would really appreciate it. |
Collaborator
|
I'm not familiar with the CI workflows in this repo anymore but looks like there are just some formatting errors related to trailing spaces. |
Remove empty space
Format code
Contributor
Author
|
@yonaskolb I removed extra spaces. Thanks! |
Contributor
|
Thanks @mirkokg. We can merge it once CI is green. |
Contributor
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate permanent references for PBXFileSystemSynchronizedExceptionSet objects, including build file and build phase exception sets. Updates tests to verify that references for exception sets are correctly converted to permanent values.
Resolves #934
Short description 📝
When creating projects with PBXFileSystemSynchronizedRootGroup objects that contain exception sets (PBXFileSystemSynchronizedBuildFileExceptionSet or PBXFileSystemSynchronizedGroupBuildPhaseMembershipExceptionSet), the exception set IDs were being written with TEMP_ prefixes instead of proper deterministic IDs.
Solution 📦
Extended the ReferenceGenerator to process exception sets when generating references for synchronized root groups. Added a new generateExceptionSetReferences method that:
This follows the same pattern used for other object types in the reference generator.
Implementation 👩💻👨💻