-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ft subgoal problem #133
Ft subgoal problem #133
Conversation
…bgoal (subgoal0) still has effect on the planning problem. problem?
…rol is achieved on top of position control.
…to checks in the example, you can just use the previous commit. If you like the checks, you can use this one :).
last commit is with some checks to see if the orientation is actually considered. If you don't want to checks in the example, you can just use the previous commit. If you like the checks, you can use this one :). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @saraybakker1 ,
this is really helpful because it is such a common use-case. Also, nice to add a kuka example here.
I want to have more understanding of the evdev issue, and limit the changes to the poetry.lock file before merging, but I will take care of that tomorrow.
Concerning the comment about moving the robot model to the robotmodels repo, that is for the future because it affects not only this PR, but many examples on the develop
branch.
I also left some minor comments, which might be interesting for you.
poetry.lock
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is there so much changed in this file?
I understand some changes due to the evdev dependency, but 3334 lines seems excessive. I'll try to limit that.
…he forward kinematics computation. Improves code style.
Hi @maxspahn, I saw you adapted the example, are you okay with merging it into main or should I still do some adaptations? |
added an example with the orientations for the kuka, such that you can completely determine the position and orientation of the kuka robot. simulation done in pybullet still. One thing: might be nice to remove the urdfs from the example folder and put it is in a urdfs folder (with the meshes inside).