Skip to content

Update to current #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6,659 commits into from
Jan 25, 2021
Merged

Update to current #1

merged 6,659 commits into from
Jan 25, 2021

Conversation

tspence
Copy link
Owner

@tspence tspence commented Jan 25, 2021

This PR fixes #

sandy081 and others added 30 commits January 20, 2021 09:41
* code catchup

* state service - actually implement interface

* refactor cli main to follow our patterns

* 💄
We really need a lint rule or something for awaiting/not calling functions
fs.realpath.native in NodeJS uses the Win32 API function GetFinalPathNameByHandle() on Windows hosts,
therefore a given path must follow the guidelines for Win32 API file functions.
Drive letters on Windows need to end on a backslash according to the Win32 File Naming Conventions (https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file)
Omitting the backslash results in Windows treating the remaining path components as a relative path starting from the current directory on the specified disk
https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file#fully-qualified-vs-relative-paths
Jackson Kearl and others added 29 commits January 22, 2021 20:24
* wip

* clean up

* more test cleanup

* cleanup more

* more cleanup
* bring back grammar extensions

* fix hygiene

* Revert "pull themes from the marketplace"

This reverts commit 0738f76.
@tspence tspence merged commit 8916a7a into tspence:master Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.