Breadcrumbs: drive letter is lowercase

[bpasero]

I noticed that a file I open that is not inside the workspace appears with a lowercase drive letter:

I thought our label provider takes care of uppercasing if presented as label, such as the editor tabs do (when breadcrumbs are disabled):

Not sure if this is a label provider issue or not.

[jrieken]

@bpasero this is using the value of getOriginalUri

[bpasero]

@jrieken yeah that is fine, we have a way to always uppercase the drive letter when it is being displayed to the user independent from how it is passed into the editor or how the URI was created:

LabelService:

vscode/src/vs/workbench/services/label/common/labelService.ts

Lines 286 to 288 in dcc1e9d

	if (formatting.normalizeDriveLetter && hasDriveLetter(label.substr(1))) {
	label = label.charAt(1).toUpperCase() + label.substr(2);
	}

More generic method without service:

vscode/src/vs/base/common/labels.ts

Lines 95 to 101 in 6756381

	export function normalizeDriveLetter(path: string): string {
	if (hasDriveLetter(path)) {
	return path.charAt(0).toUpperCase() + path.slice(1);
	}
	return path;
	}

I think Windows is typically showing drive letters in uppercase, so we did so too:

[jrieken]

Yeah, I believe my question is why getOriginalUri isn't doing this? Its doc says: "and should be used whenever the URI is presented to the user" which you now says in't true

[bpasero]

@jrieken originalUri is the thing that was passed to the editor when opening and that can be different from the canonical URI as such you are using the right kind of URI. However, when the URI is created it can have any form of uppercase or lowercase drive letter (for the file access it doesn't really matter). Only when we display the URI as a label to the user, we need to use the label service to get consistent display. I do not think the originalUri should be doing that because it literally just passes on what it got.

[jrieken]

I'd say the comment for getOriginalUri is bogous/misleading. Nevertheless, I can do all the tweaks but I actually do use a ResourceLabel which consumes the label service. So, this might actually @isidorn after all.

vscode/src/vs/workbench/browser/parts/editor/breadcrumbsControl.ts

Line 134 in 475d346

label.element.setFile(this.element.uri, {

[bpasero]

Yeah good point, I have updated the JSDoc:

The original URI of an editor is the URI that was used originally to open the editor and should be used whenever the URI is presented to the user, e.g. as a label together with utility methods such as `ResourceLabel` or `ILabelService` that can turn this original URI into the best form for presenting.

[isidorn]

Sounds like the labelService does not normalize the drive letter for uris outside of the workspace. Let me assign to January and I can investigate this week