Skip to content

Draft governance model #3188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Conversation

benjeffery
Copy link
Member

I've created this PR on the tskit repo for visibility - eventually this will live at https://github.com/tskit-dev/administrative.

Following the meeting and discussion yesterday, I've written up what I consider to be the lightest, yet focused and meaningful, governance policy for the core repositories.

Please provide your feedback on this, even if it's just a +1 if you're happy, as we'd like community consensus on this.

Copy link

codecov bot commented Jun 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.63%. Comparing base (1537830) to head (06ac675).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3188      +/-   ##
==========================================
+ Coverage   89.62%   89.63%   +0.01%     
==========================================
  Files          28       28              
  Lines       31969    32004      +35     
  Branches     5873     5879       +6     
==========================================
+ Hits        28653    28688      +35     
  Misses       1886     1886              
  Partials     1430     1430              
Flag Coverage Δ
c-tests 86.66% <ø> (ø)
lwt-tests 80.38% <ø> (ø)
python-c-tests 88.18% <ø> (ø)
python-tests 98.86% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!


- proposing, discussing, or reviewing a change to the code, documentation, or specification
via a GitHub pull request to the above repositories;
- reporting a GitHub issue or starting a discussion on the above repositories;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the process for someone getting added to the github org? (I don't know, just asking the question for visibility)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to set this up and have a clean out of permissions across the repos. It's under settings on the org page.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant what's the process for deciding whether someone should be in the Org or not. That's something we should document

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good but in vague terms; too prescriptive might go out of date (as for instance perhaps possible github roles change)

perhaps some general principles - like "the steering committee will choose roles in the github org so that X Y and Z"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah I see this has been added below

- [kastore - key-value store](http://github.com/tskit-dev/kastore)
- [administrative](http://github.com/tskit-dev/administrative)
- [.github - common config](http://github.com/tskit-dev/.github)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have this laid out. Do we want explicitly say the other repos on the tskit-dev workspace (e.g. tscompress, tsinfer) may become the responsibility of other maintainers if need be, or is that too prescriptive?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about this, but decided, as they are out of scope for this document, that it shouldn't say anything about them.

@hyanwong
Copy link
Member

hyanwong commented Jun 5, 2025

I like this. Not too heavyweight, just does what's needed. +1 from me.

@nspope
Copy link
Contributor

nspope commented Jun 5, 2025

Looks great to me-- simple and transparent.

GOVERNANCE.md Outdated
via a GitHub pull request to the above repositories;
- reporting a GitHub issue or starting a discussion on the above repositories;

Potential contributors are encouraged to read and abide by the [CODE OF CONDUCT](https://github.com/tskit-dev/.github/blob/main/CODE_OF_CONDUCT.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Potential contributors are encouraged to read and abide by the [CODE OF CONDUCT](https://github.com/tskit-dev/.github/blob/main/CODE_OF_CONDUCT.md).
Potential contributors are expected to abide by the [CODE OF CONDUCT](https://github.com/tskit-dev/.github/blob/main/CODE_OF_CONDUCT.md).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I put "encouraged" as the contributors are "potential" but I agree that stronger wording here is better. Maybe even remove the "potential" e.g. "contributors are required to abide by"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or even "contributors must abide by"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed in c05939a

benjeffery and others added 2 commits June 11, 2025 23:36
Co-authored-by: Peter Ralph <petrel.harp@gmail.com>
Co-authored-by: Peter Ralph <petrel.harp@gmail.com>
GOVERNANCE.md Outdated

Decisions about the future of the project are made through discussion with all
members of the community. All non-sensitive project management discussion takes
place on the issue trackers of the appropriate repositories.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
place on the issue trackers of the appropriate repositories.
place in the issue trackers of the appropriate repositories
or other public forums.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOVERNANCE.md Outdated
Decisions about the future of the project are made through discussion with all
members of the community. All non-sensitive project management discussion takes
place on the issue trackers of the appropriate repositories.
Where possible decisions and discussions of the steering council should be documented as issues on the [administrative](https://github.com/tskit-dev/administrative) repository. Sensitive discussion may occur via email to admin@tskit.dev.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the idea about emailing admin? to have record of things? I'd vote to remove the last sentence?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a way to encourage things not to go through personal email as the admin address will have a record for all the SC members. I get your point that this maybe promotes that too much. Removed in 06ac675

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants