Fix osx tests #2935
Merged
Fix osx tests #2935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2935 +/- ##
==========================================
+ Coverage 89.62% 89.63% +0.01%
==========================================
Files 29 29
Lines 30176 30176
Branches 5874 5874
==========================================
+ Hits 27044 27048 +4
+ Misses 1793 1789 -4
Partials 1339 1339
Flags with carried forward coverage won't be shown. Click here to find out more. |
benjeffery
force-pushed
the
fix-osx
branch
17 times, most recently
from
7798c9d to
eb9e9ae
Compare
benjeffery
force-pushed
the
fix-osx
branch
5 times, most recently
from
ea519c9 to
7ffdf27
Compare
|
Well this was fun. The base osx image has changed, so conda paths have moved, libraries that we need were missing, and some tests failed due to tiny numerical differences. |
|
Thanks @benjeffery, heroic stuff! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.