Remove tree.left_root #1862
Merged
Remove tree.left_root #1862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromekelleher
force-pushed
the
leftrootectomy
branch
2 times, most recently
from
6b960af to
1818f84
Compare
Codecov Report
@@ Coverage Diff @@
## main #1862 +/- ##
==========================================
- Coverage 93.14% 93.13% -0.01%
==========================================
Files 27 27
Lines 24960 24929 -31
Branches 1099 1095 -4
==========================================
- Hits 23248 23217 -31
Misses 1677 1677
Partials 35 35
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jeromekelleher
force-pushed
the
leftrootectomy
branch
from
1818f84 to
a5e6eeb
Compare
jeromekelleher
force-pushed
the
leftrootectomy
branch
from
a5e6eeb to
963f840
Compare
|
This is ready to go in I think - I've created #1886 to track updating the documentation, which needs some better examples. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #1861
Closes #1796
The cases where we actually do want to explicitly iterate over the roots are rare; it's much better to push the virtual root onto a stack and let the general tree algorithms take care of things. So, there will be a bit of breakage in user code, but I think it's worth it to move them onto better ways of doing things.
TODO - the examples need updating here and we need some changelogging