Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance regression for full LD matrix #1905

Open
jeromekelleher opened this issue Nov 10, 2021 · 0 comments
Open

Performance regression for full LD matrix #1905

jeromekelleher opened this issue Nov 10, 2021 · 0 comments
Labels
C API Issue is about the C API Performance This issue addresses performance, either runtime or memory Python API Issue is about the Python API

Comments

@jeromekelleher
Copy link
Member

#1864 updated the LdCalculator code to remove some complicated optimisations. This lead to a performance regression when computing the full LD matrix in some cases (see this comment #1864 (comment))

When developing the new LD APIs (#1900) and algorithms we should compare performance against the code in version 0.3.7 as well as the current main. There were some good ideas in the old code about how to minimise tree transitions using an inner and outer tree when computing lots of pairwise LD values in a predictable pattern, hopefully we can reuse most of this and regain the old performance.

We can close this issue once we have either confirmed we recover the old performance, or decided we don't care.

@jeromekelleher jeromekelleher added C API Issue is about the C API Python API Issue is about the Python API Performance This issue addresses performance, either runtime or memory labels Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C API Issue is about the C API Performance This issue addresses performance, either runtime or memory Python API Issue is about the Python API
Projects
None yet
Development

No branches or pull requests

1 participant