Return None for invalid row indexes #350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding a test that iterating over empty tables gave a count of zero |
This affects some, but not all, table getters: * functions to return metadata now return Option<Result<_, _>> instead of Result<Option<_>, _>. * Site ancestral state and mutation derived state now return Option<&[u8]> instead of Result<&[u8], TskitError> The justification for this is that the new behavior is more idiomatic. (Consider Vec::get, which returns None if the index is invalid.) BREAKING CHANGE: return values have changed
molpopgen
force-pushed
the
none_when_metadata_row_not_valid
branch
from
cc6f5ce to
cd541b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For metadata, site ancestral, mutation derived states:
Cannot merge until we validate the new
versions of "make a table row".
It seems that we have a testing gap here.
Closes #327