examples show better pattern

Author: molpopgen

src/individual_table.rs

@@ -308,10 +308,12 @@ build_owned_table_type!(
     /// let rowid = individuals.add_row_with_metadata(0, None, None, &metadata).unwrap();
     /// assert_eq!(rowid, 0);
     ///
-    /// if let Some(Ok(decoded)) = individuals.metadata::<IndividualMetadata>(rowid) {
-    ///     assert_eq!(decoded.value, 42);
-    /// } else {
-    ///     panic!("hmm...we expected some metadata!");
+    /// match individuals.metadata::<IndividualMetadata>(rowid) {
+    ///     // rowid is in range, decoding succeeded
+    ///     Some(Ok(decoded)) => assert_eq!(decoded.value, 42),
+    ///     // rowid is in range, decoding failed
+    ///     Some(Err(e)) => panic!("error decoding metadata: {:?}", e),
+    ///     None => panic!("row id out of range")
     /// }
     ///
     /// # }

src/migration_table.rs

@@ -242,10 +242,12 @@ build_owned_table_type!(
     /// let rowid = migrations.add_row_with_metadata((0., 1.), 1, (0, 1), 10.3, &metadata).unwrap();
     /// assert_eq!(rowid, 0);
     ///
-    /// if let Some(Ok(decoded)) = migrations.metadata::<MigrationMetadata>(rowid) {
-    ///     assert_eq!(decoded.value, 42);
-    /// } else {
-    ///     panic!("hmm...we expected some metadata!");
+    /// match migrations.metadata::<MigrationMetadata>(rowid) {
+    ///     // rowid is in range, decoding succeeded
+    ///     Some(Ok(decoded)) => assert_eq!(decoded.value, 42),
+    ///     // rowid is in range, decoding failed
+    ///     Some(Err(e)) => panic!("error decoding metadata: {:?}", e),
+    ///     None => panic!("row id out of range")
     /// }
     ///
     /// # }

src/mutation_table.rs

@@ -231,12 +231,13 @@ build_owned_table_type!(
 /// let rowid = mutations.add_row_with_metadata(0, 1, 5, 10.0, None, &metadata).unwrap();
 /// assert_eq!(rowid, 0);
 ///
-/// if let Some(Ok(decoded)) = mutations.metadata::<MutationMetadata>(rowid) {
-///     assert_eq!(decoded.value, 42);
-/// } else {
-///     panic!("hmm...we expected some metadata!");
+/// match mutations.metadata::<MutationMetadata>(rowid) {
+///     // rowid is in range, decoding succeeded
+///     Some(Ok(decoded)) => assert_eq!(decoded.value, 42),
+///     // rowid is in range, decoding failed
+///     Some(Err(e)) => panic!("error decoding metadata: {:?}", e),
+///     None => panic!("row id out of range")
 /// }
-///
 /// # }
 /// ```
     => OwnedMutationTable,

src/node_table.rs

@@ -285,10 +285,12 @@ build_owned_table_type!(
     /// let rowid = nodes.add_row_with_metadata(0, 1., -1, -1, &metadata).unwrap();
     /// assert_eq!(rowid, 0);
     ///
-    /// if let Some(Ok(decoded)) = nodes.metadata::<NodeMetadata>(rowid) {
-    ///     assert_eq!(decoded.value, 42);
-    /// } else {
-    ///     panic!("hmm...we expected some metadata!");
+    /// match nodes.metadata::<NodeMetadata>(rowid) {
+    ///     // rowid is in range, decoding succeeded
+    ///     Some(Ok(decoded)) => assert_eq!(decoded.value, 42),
+    ///     // rowid is in range, decoding failed
+    ///     Some(Err(e)) => panic!("error decoding metadata: {:?}", e),
+    ///     None => panic!("row id out of range")
     /// }
     ///
     /// # }

src/population_table.rs

@@ -152,12 +152,13 @@ build_owned_table_type!(
 /// let rowid = populations.add_row_with_metadata(&metadata).unwrap();
 /// assert_eq!(rowid, 0);
 ///
-/// if let Some(Ok(decoded)) = populations.metadata::<PopulationMetadata>(rowid) {
-///     assert_eq!(&decoded.name, "YRB");
-/// } else {
-///     panic!("hmm...we expected some metadata!");
+/// match populations.metadata::<PopulationMetadata>(rowid) {
+///     // rowid is in range, decoding succeeded
+///     Some(Ok(decoded)) => assert_eq!(&decoded.name, "YRB"),
+///     // rowid is in range, decoding failed
+///     Some(Err(e)) => panic!("error decoding metadata: {:?}", e),
+///     None => panic!("row id out of range")
 /// }
-///
 /// # }
 /// ```
     => OwnedPopulationTable,

src/site_table.rs

@@ -180,12 +180,13 @@ build_owned_table_type!(
     /// let rowid = sites.add_row_with_metadata(0., None, &metadata).unwrap();
     /// assert_eq!(rowid, 0);
     ///
-    /// if let Some(Ok(decoded)) = sites.metadata::<SiteMetadata>(rowid) {
-    ///     assert_eq!(decoded.value, 42);
-    /// } else {
-    ///     panic!("hmm...we expected some metadata!");
+    /// match sites.metadata::<SiteMetadata>(rowid) {
+    ///     // rowid is in range, decoding succeeded
+    ///     Some(Ok(decoded)) => assert_eq!(decoded.value, 42),
+    ///     // rowid is in range, decoding failed
+    ///     Some(Err(e)) => panic!("error decoding metadata: {:?}", e),
+    ///     None => panic!("row id out of range")
     /// }
-    ///
     /// # }
     /// ```
     => OwnedSiteTable,