Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positive: TypeScript type definition dist\index.d.ts is not part of the files list #69

Closed
Lusito opened this issue May 6, 2020 · 3 comments
Closed

False positive: TypeScript type definition dist\index.d.ts is not part of the files list #69

Lusito opened this issue May 6, 2020 · 3 comments

Comments

@Lusito
Copy link
Contributor

Lusito commented May 6, 2020

Currently digging into your tool and I got the above error.
I have the whole folder included:

"files": [
    "dist"
  ],
@papb
Copy link
Contributor

papb commented May 6, 2020

Looks like it is included... Can you clarify what you mean?

@Lusito
Copy link
Contributor Author

Lusito commented May 7, 2020 •
edited
Loading

Sorry, I guess that was a bit unclear: I am running TSD on my project and it complains about my package.json, where I do have the whole directory included in the files part.

I.e. the check TSD does, does not cover the case of directories being specified in the files array. It assumes you specify your files one by one, which is ridiculous for some projects.

@Lusito Lusito changed the title TypeScript type definition dist\index.d.ts is not part of the files list False positive: TypeScript type definition dist\index.d.ts is not part of the files list May 7, 2020
@AndrewLeedham
Copy link

I am also seeing this. Would be great to see it included :)

@SamVerschueren SamVerschueren mentioned this issue Jun 29, 2020
Closed
SamVerschueren pushed a commit that referenced this issue Jun 29, 2020
@Lusito @SamVerschueren
Add support for globbing patterns in files property - fixes #69 (#70)
56b90ab
@SamVerschueren SamVerschueren mentioned this issue Jul 4, 2020
Closed
@dependabot dependabot bot mentioned this issue Mar 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump tsd from 0.11.0 to 0.14.0 veritem/fastify-kafka
3 participants
@Lusito @AndrewLeedham @papb