Add support for globbing patterns in files property - fixes #69 (#70)

Author: Lusito

source/lib/rules/files-property.ts

@@ -1,5 +1,6 @@
 import * as path from 'path';
 import * as fs from 'fs';
+import * as globby from 'globby';
 import {Context, Diagnostic} from '../interfaces';
 import {getJSONPropertyPosition} from '../utils';
 
@@ -17,7 +18,7 @@ export default (context: Context): Diagnostic[] => {
 	}
 
 	const normalizedTypingsFile = path.normalize(typingsFile);
-	const normalizedFiles = (pkg.files as string[]).map(path.normalize);
+	const normalizedFiles = globby.sync(pkg.files as string[], {cwd: context.cwd}).map(path.normalize);
 
 	if (normalizedFiles.includes(normalizedTypingsFile)) {
 		return [];

source/test/fixtures/files-folder/out/index.d.ts

@@ -0,0 +1,6 @@
+declare const concat: {
+	(foo: string, bar: string): string;
+	(foo: number, bar: number): number;
+};
+
+export default concat;

source/test/fixtures/files-folder/out/index.js

@@ -0,0 +1,3 @@
+module.exports.default = (foo, bar) => {
+	return foo + bar;
+};

source/test/fixtures/files-folder/out/index.test-d.ts

@@ -0,0 +1,5 @@
+import {expectType} from '../../../..';
+import concat from '.';
+
+expectType<string>(concat('foo', 'bar'));
+expectType<number>(concat(1, 2));

source/test/fixtures/files-folder/package.json

@@ -0,0 +1,7 @@
+{
+	"name": "foo",
+	"files": [
+		"out"
+	],
+	"types": "out/index.d.ts"
+}

source/test/fixtures/files-glob/out/index.d.ts

@@ -0,0 +1,6 @@
+declare const concat: {
+	(foo: string, bar: string): string;
+	(foo: number, bar: number): number;
+};
+
+export default concat;

source/test/fixtures/files-glob/out/index.js

@@ -0,0 +1,3 @@
+module.exports.default = (foo, bar) => {
+	return foo + bar;
+};

source/test/fixtures/files-glob/out/index.test-d.ts

@@ -0,0 +1,5 @@
+import {expectType} from '../../../..';
+import concat from '.';
+
+expectType<string>(concat('foo', 'bar'));
+expectType<number>(concat(1, 2));

source/test/fixtures/files-glob/package.json

@@ -0,0 +1,8 @@
+{
+	"name": "foo",
+	"files": [
+		"out/**/*.d.ts",
+		"out/**/*.js"
+	],
+	"types": "out/index.d.ts"
+}

source/test/test.ts

@@ -36,6 +36,18 @@ test('fail if typings file is not part of `files` list', async t => {
 	]);
 });
 
+test('allow specifying folders containing typings file in `files` list', async t => {
+	const diagnostics = await tsd({cwd: path.join(__dirname, 'fixtures/files-folder')});
+
+	verify(t, diagnostics, []);
+});
+
+test('allow specifying glob patterns containing typings file in `files` list', async t => {
+	const diagnostics = await tsd({cwd: path.join(__dirname, 'fixtures/files-glob')});
+
+	verify(t, diagnostics, []);
+});
+
 test('fail if `typings` property is used instead of `types`', async t => {
 	const diagnostics = await tsd({cwd: path.join(__dirname, 'fixtures/types-property/typings')});