Skip to content

chore: re-enable cellranger tests (TCP-105) #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bcai2 merged 2 commits into from
Oct 7, 2022
Merged

chore: re-enable cellranger tests (TCP-105) #268

bcai2 merged 2 commits into from
Oct 7, 2022

Conversation

@bcai2
Copy link
Contributor

@bcai2 bcai2 commented Oct 7, 2022 •
edited
Loading

  • Re-enables cellranger tests for CI.
  • Refactors local cellranger test to download individual files, instead of downloading and unzipping a tarball of files.
  • Refactors S3 cellranger test to use an S3 prefix (containing uncompressed files) instead of a S3-stored .tar.gz archive of the "directory" of files.

Note: .tar.gz inputs for cellranger can no longer be passed via S3 URLs.

@bcai2 bcai2 changed the title chore: re-enable cellranger tests chore: re-enable cellranger tests (TCP-105) Oct 7, 2022
@bcai2 bcai2 marked this pull request as ready for review October 7, 2022 21:46
@bcai2 bcai2 requested review from jherr-dev and lebovic October 7, 2022 21:47
@bcai2 bcai2 merged commit a66df1b into staging Oct 7, 2022
@bcai2 bcai2 deleted the chore/reenable-cellranger-tests branch October 7, 2022 22:17
@bcai2 bcai2 mentioned this pull request Nov 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lebovic lebovic Awaiting requested review from lebovic

1 more reviewer

@jherr-dev jherr-dev jherr-dev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bcai2 @jherr-dev