Standardize and document ensure_element method of Session#75
Merged
lordjabez merged 5 commits intotryolabs:masterfrom Feb 4, 2024
bmos:ensure_element
Merged
Standardize and document ensure_element method of Session#75lordjabez merged 5 commits intotryolabs:masterfrom bmos:ensure_element
lordjabez merged 5 commits intotryolabs:masterfrom
bmos:ensure_element
Conversation
bmos
changed the title
Collaborator
|
Thanks for the contribution, @bmos ! This is a nice improvement. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ensure_element method doesn't accept the standard locator strategy names, because the names used internally to this module use underscores instead of spaces.
This PR standardizes the calls in this module to use Selenium's standard names internally, while allowing for backwards compatibility for users who may be using the un-documented method as it was. Users using the underscored names will see a DeprecationWarning to alert them to the change, eventually allowing this extra code to be removed from this module.
I have run pytest and all the tests passed 👍🏻