find_element / ensure_element

[bmos]

Selenium has moved from find_element_*(s) to find_element(By.*, s)
https://www.selenium.dev/documentation/webdriver/elements/finders/

It would be nice to have this same approach available for ensure_element like this:

fruits = s.driver.ensure_element(By.ID, "fruits")

[lordjabez]

That ought to be an easy addition. Want to write up a PR for it?

[bmos]

oh weird...
it seems like it's already there but it doesn't accept the standard names with spaces

requestium/requestium/requestium.py

Lines 283 to 342 in 0b9945f

	def ensure_element(self, locator, selector, state="present", timeout=None):
	"""This method allows us to wait till an element appears or disappears in the browser
	The webdriver runs in parallel with our scripts, so we must wait for it everytime it
	runs javascript. Selenium automatically waits till a page loads when GETing it,
	but it doesn't do this when it runs javascript and makes AJAX requests.
	So we must explicitly wait in that case.
	The 'locator' argument defines what strategy we use to search for the element.
	The 'state' argument allows us to chose between waiting for the element to be visible,
	clickable, present, or invisible. Presence is more inclusive, but sometimes we want to
	know if the element is visible. Careful, its not always intuitive what Selenium considers
	to be a visible element. We can also wait for it to be clickable, although this method
	is a bit buggy in selenium, an element can be 'clickable' according to selenium and
	still fail when we try to click it.
	More info at: http://selenium-python.readthedocs.io/waits.html
	"""
	locators = {'id': By.ID,
	'name': By.NAME,
	'xpath': By.XPATH,
	'link_text': By.LINK_TEXT,
	'partial_link_text': By.PARTIAL_LINK_TEXT,
	'tag_name': By.TAG_NAME,
	'class_name': By.CLASS_NAME,
	'css_selector': By.CSS_SELECTOR}
	locator = locators[locator]
	if not timeout:
	timeout = self.default_timeout
	if state == 'visible':
	element = WebDriverWait(self, timeout).until(
	expected_conditions.visibility_of_element_located((locator, selector))
	)
	elif state == 'clickable':
	element = WebDriverWait(self, timeout).until(
	expected_conditions.element_to_be_clickable((locator, selector))
	)
	elif state == 'present':
	element = WebDriverWait(self, timeout).until(
	expected_conditions.presence_of_element_located((locator, selector))
	)
	elif state == 'invisible':
	WebDriverWait(self, timeout).until(
	expected_conditions.invisibility_of_element_located((locator, selector))
	)
	element = None
	else:
	raise ValueError(
	"The 'state' argument must be 'visible', 'clickable', 'present' "
	"or 'invisible', not '{}'".format(state)
	)
	# We add this method to our element to provide a more robust click. Chromedriver
	# sometimes needs some time before it can click an item, specially if it needs to
	# scroll into it first. This method ensures clicks don't fail because of this.
	if element:
	element.ensure_click = functools.partial(_ensure_click, element)
	return element

See #75

[lordjabez]

Fixed by #75