feat(lume): restructure release as .app bundle for bridged networking#1086
Draft
feat(lume): restructure release as .app bundle for bridged networking#1086
Conversation
- Update MockVM.run() signature to include networkMode and clipboard parameters added to the VM base class - Update VMDetailsPrinterTests to expect the network column in table output
…working Restructure the lume release artifact from a standalone CLI binary into a macOS .app bundle so that a provisioning profile can be loaded by the OS, enabling the com.apple.vm.networking restricted entitlement for bridged networking support in release builds. Closes #1076
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
Contributor
📦 Publishable packages changed
Add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.appbundlecom.apple.vm.networkingentitlement (removed in fix(lume): remove com.apple.vm.networking from release entitlements #1075)--network bridged) in release buildsWhy
.appbundle?The
com.apple.vm.networkingentitlement is restricted and requires a provisioning profile. macOS only loads provisioning profiles from.appbundles, not standalone binaries.Changes
libs/lume/resources/Info.plist— bundle metadata templatelibs/lume/resources/lume.entitlements— re-addedcom.apple.vm.networkinglibs/lume/scripts/build/build-release-notarized.sh— assembles.appbundlelibs/lume/scripts/build/build-release.sh— local.appbundle buildlibs/lume/scripts/install.sh— installs.appbundle + wrapper scriptlibs/lume/scripts/install-local.sh— conditional.appfor--bridged-entitlementlibs/lume/scripts/uninstall.sh— cleans up.appbundle.github/workflows/cd-swift-lume.yml— provisioning profile secretBlocked on
com.apple.vm.networkingentitlement (feat(lume): pending Apple entitlement for com.apple.vm.networking #1085)PROVISIONING_PROFILE_BASE64GitHub Actions secretRelated
--network bridged) #1007