Simplify Store trait #195
Merged
Simplify Store trait #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosthene-nitrokey
approved these changes
Jan 31, 2025
This patch simplifies the Store trait by removing the Fs wrapper struct, the Storage types, the static lifetime and the Copy requirement and replaces it with a reference to a DynFilesystem. This gives runners more options on how to implement the store. As the Store trait can now easily be implemented in a safe way, this patch also removes the unsafe keyword from the trait definition.
robin-nitrokey
force-pushed
the
dyn-fs
branch
from
609d906 to
5003249
Compare
This was referenced Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch simplifies the Store trait by removing the Fs wrapper struct, the Storage types, the static lifetime and the Copy requirement and replaces it with a reference to a DynFilesystem.
This gives runners more options on how to implement the store.
As the Store trait can now easily be implemented in a safe way, this patch also removes the unsafe keyword from the trait definition.