Skip to content

Conversation

@robin-nitrokey
Copy link
Member

Depends on:

Alternatively, we could completely drop the Store trait and just use a struct with three references. To be tested whether that is more efficient.

@sosthene-nitrokey
Copy link
Contributor

 Is this really necessary?

@robin-nitrokey
Copy link
Member Author

It is not necessary, but I think it has multiple benefits: It leads to simpler code. It allows us to get rid of the unnecessary Fs type that is just another level of indirection and another static mut. And it allows us to be more flexible in Store implementations, especially e. g. for the virtual runners or when replacing a storage with RAM. So I would rather ask the question: Why do we need these type parameters?

@sosthene-nitrokey
Copy link
Contributor

Good!

@robin-nitrokey
Copy link
Member Author

Replaced by #195.

@robin-nitrokey robin-nitrokey deleted the store branch February 28, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants