CompatHelper: bump compat for ForwardDiff to 1, (keep existing compat) #2320
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ranocha
force-pushed
the
compathelper/new_version/2025-03-27-00-05-21-087-01715210426
branch
from
5aea096 to
3f03732
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2320 +/- ##
=======================================
Coverage 96.77% 96.77%
=======================================
Files 495 495
Lines 41055 41055
=======================================
Hits 39727 39727
Misses 1328 1328
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
ForwardDiff v1 is not yet used here, which is just as well given that it does not seem to work yet with OrdinaryDiffEq (SciML/OrdinaryDiffEq.jl#2643) |
|
The corresponding PR in OrdinaryDiffEq.jl has been merged and new versions have been registered. So hopefully, we can test ForwardDiff.jl v1 here. |
|
Needs ranocha/SummationByPartsOperators.jl#332 before. |
|
Next one to wait for is Octavian.jl. There, CompatHelper is even disabled due to inactivity in the repo... |
|
The journey continues. The next one is PathIntersections.jl. Could you take care of that please, @jlchan? I.e. allow ForwardDiff.jl v1 in the Project.toml. |
|
@cgt3 I'm away from my computer the next couple of days - any chance you could bump ForwardDiff's compat to 1? If not I can do it on Monday. |
|
@jlchan Sure; I'll try to take care of it today. |
|
@jlchan and @JoshuaLampert I believe I have updated PathIntersections.jl to allow ForwardDiff.jl v1. Let me know if you need something else updated. |
|
Thank you! Would you mind releasing a new version so we can bump our compact in Trixi.jl? |
|
Can do 👍 . I'll try to get that done tomorrow. |
|
@jlchan new version (v0.3.0) for PathIntersections.jl is up. |
|
Thanks! Now StartUpDG.jl has to allow PathIntersections.jl v0.3. Could you please update the compat bound accordingly, @jlchan? |
|
Yep! Thanks for your patience with time zone differences. Here's the new version PR JuliaRegistries/General#132594 I am doing this on my phone while traveling; if any serious issues arise I can address them when I'm back to my laptop tomorrow. |
|
Thanks! However, it seems you didn't actually register v0.3.0 of PathIntersections.jl yet, @cgt3 (see here for how it was done for v0.2.0). Can you or @jlchan please do that? And don't forget to also add release notes as explained in the comment by |
This comment was marked as outdated.
This comment was marked as outdated.
|
Thanks for the heads up. I added release notes and pinged JuliaRegistrator cgt3/PathIntersections.jl@2261662 Do we need to remove the old manually tagged release to have Tagbot trigger properly? |
|
@JoshuaLampert PathIntersections 0.3 was successfully registered. Let us know if it works for you? |
|
ForwardDiff.jl v1.0.1 is used in the tests (see, e.g., here), which is good. However, there are errors when trying to use |
Even though the errors are related to ForwardDiff.jl, they seem to be unrelated to the version bump because the same error also happens in other PRs (like here), where ForwardDiff.jl v0.10 is stilled used. Edit: Very likely to come from SciML/OrdinaryDiffEq.jl#2732. |
|
Sorry I forgot all about the registrator. Thanks @jlchan for fixing it. |
Could you please open an issue there? |
I created SciML/OrdinaryDiffEq.jl#2738. |
|
Thanks! |
ranocha
deleted the
compathelper/new_version/2025-03-27-00-05-21-087-01715210426
branch
This pull request changes the compat entry for the
ForwardDiffpackage from0.10.36to0.10.36, 1.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.