Skip to content

Bump compat of ForwardDiff.jl to v1 #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2025

Conversation

JoshuaLampert
Copy link
Contributor

No description provided.

@JoshuaLampert
Copy link
Contributor Author

The failures on nightly are probably spurious and unrelated to this PR.

Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me. I cannot merge it since some CI jobs fail and I do not have admin priviliges.

@chriselrod
Copy link
Collaborator

Thanks, this looks good to me. I cannot merge it since some CI jobs fail and I do not have admin priviliges.

Try again.

@ranocha ranocha enabled auto-merge (squash) June 6, 2025 13:59
@ranocha
Copy link
Member

ranocha commented Jun 6, 2025

I can only enable auto-merge - which is blocked since the nightly tests are required to pass.

@chriselrod chriselrod disabled auto-merge June 6, 2025 18:29
@chriselrod chriselrod merged commit 9b900ac into JuliaLinearAlgebra:master Jun 6, 2025
17 of 23 checks passed
@chriselrod
Copy link
Collaborator

I tried taking off a branch protection, but it seems overriding the default still required admin privileges.
I've now added you as an admin.

@ranocha
Copy link
Member

ranocha commented Jun 6, 2025

Thanks a lot!

@JoshuaLampert JoshuaLampert deleted the forwarddiff-v1 branch June 6, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants