Skip to content

[AMD] Remove f8 dtypes in type checking for gfx12 #6628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[AMD] Remove f8 dtypes in type checking for gfx12 #6628

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions third_party/amd/backend/compiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,9 @@ def parse_options(self, opts) -> Any:
supported_fp8_dtypes.update({'fp8e4nv', 'fp8e4b8', 'fp8e5b16'})
elif self.target.arch == 'gfx950':
supported_fp8_dtypes.update({'fp8e4nv', 'fp8e5'})
elif 'gfx12' in self.target.arch:
# Triton does not support f8 dtypes for gfx12 target yet.
supported_fp8_dtypes.update({})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about making the default in HIPOptions as empty and set the proper ones for each arch in the above so we don't need to explictly mention an arch does not support any yet?

args["supported_fp8_dtypes"] = tuple(sorted(supported_fp8_dtypes))

if "enable_fp_fusion" not in opts:
Expand Down
Loading