[AMD] Remove f8 dtypes in type checking for gfx12 #6628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently Triton does not support f8 dtypes for gfx12. As a stub, remove all f8 in type checking to make failure message clearer Signed-off-by: Ilya Veselov <iveselov.nn@gmail.com>
antiagainst
requested changes
Apr 29, 2025
| @@ -113,6 +113,9 @@ def parse_options(self, opts) -> Any: | |||
| supported_fp8_dtypes.update({'fp8e4nv', 'fp8e4b8', 'fp8e5b16'}) | |||
| elif self.target.arch == 'gfx950': | |||
| supported_fp8_dtypes.update({'fp8e4nv', 'fp8e5'}) | |||
| elif 'gfx12' in self.target.arch: | |||
| # Triton does not support f8 dtypes for gfx12 target yet. | |||
| supported_fp8_dtypes.update({}) | |||
There was a problem hiding this comment.
What about making the default in HIPOptions as empty and set the proper ones for each arch in the above so we don't need to explictly mention an arch does not support any yet?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Triton does not support f8 dtypes for gfx12. As a stub, remove all f8 in type checking to make failure message clearer