Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][Proton][AMD] Fix test_cmd and enable CI on AMD #4026

Merged
merged 7 commits into from
Jun 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/integration-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -399,6 +399,10 @@ jobs:

# Run runtime tests serially to avoid race condition with cache handling
python3 -m pytest -s runtime
- name: Run Proton tests
run: |
cd third_party/proton
python3 -m pytest test
- name: Run C++ unittests
run: |
cd python
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/integration-tests.yml.in
CRobeck marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -404,6 +404,11 @@ jobs:
# Run runtime tests serially to avoid race condition with cache handling
python3 -m pytest -s runtime

- name: Run Proton tests
run: |
cd third_party/proton
python3 -m pytest test

- *run-cpp-unittests-step
- *save-build-artifacts-step
- *inspect-cache-directories-step
Expand Down
2 changes: 1 addition & 1 deletion third_party/proton/test/test_cmd.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,4 @@ def test_exec(mode):
data = json.load(f, )
kernels = data[0]["children"]
assert len(kernels) == 2
assert kernels[1]["frame"]["name"] == "test"
assert kernels[0]["frame"]["name"] == "test" or kernels[1]["frame"]["name"] == "test"
Loading