-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI][Proton][AMD] Fix test_cmd and enable CI on AMD #4026
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upti and roctracer kernel indexes
antiagainst
reviewed
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you enable CI for this?
antiagainst
reviewed
May 28, 2024
CRobeck
changed the title
Get proton test_cmd passing on AMD
Get proton test_cmd passing on AMD and enable CI
May 28, 2024
@antiagainst the proton tests appear to pass locally. Can you take a look and see if I missed something in the yml files? |
CRobeck
changed the title
Get proton test_cmd passing on AMD and enable CI
[CI][Proton][AMD]Get proton test_cmd passing on AMD and enable CI
May 28, 2024
@antiagainst Any comments? |
Depended on: |
antiagainst
changed the title
[CI][Proton][AMD]Get proton test_cmd passing on AMD and enable CI
[CI][Proton][AMD] Fix test_cmd and enable CI on AMD
Jun 7, 2024
antiagainst
approved these changes
Jun 7, 2024
bertmaher
pushed a commit
to bertmaher/triton
that referenced
this pull request
Dec 10, 2024
Co-authored-by: Keren Zhou <kerenzhou@openai.com> Co-authored-by: Jokeren <robinho364@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.