Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting a min required cxx standard for Triton to 17.
Note in our containers default cxx is 17, thus no
-std=..
flag is shown. However, if higher version is desired, the following command:will add
-std=gnu++20
flag during build.This PR:
TRITON_MIN_CXX_STANDARD
cmake variable, which defaults to 17target_compile_features(... PRIVATE cxx_std_${TRITON_MIN_CXX_STANDARD})
, to avoid hardcoded valuesThis way to recompile Triton in higher standard, one can simply specify
-DTRITON_MIN_CXX_STANDARD=20
option for cmake command, as shown above.Related PRs:
Backends:
Note:
tensorrt_llm_backend and local_cache are already have c++17 standard, redis cache has c++20 standard specified, so these repos can be updated separately