Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump min cxx standard to 17 #6742

Merged
merged 4 commits into from
Jan 11, 2024
Merged

Conversation

oandreeva-nv
Copy link
Contributor

@oandreeva-nv oandreeva-nv commented Dec 26, 2023

Setting a min required cxx standard for Triton to 17.

Note in our containers default cxx is 17, thus no -std=.. flag is shown. However, if higher version is desired, the following command:

cmake -DTRITON_MIN_CXX_STANDARD=20 -DCMAKE_INSTALL_PREFIX:PATH=`pwd`/install .. && make -j1 VERBOSE=1 install

will add -std=gnu++20 flag during build.

This PR:

  • adds TRITON_MIN_CXX_STANDARD cmake variable, which defaults to 17
  • uses the above variable to specify cxx standard in target_compile_features(... PRIVATE cxx_std_${TRITON_MIN_CXX_STANDARD}), to avoid hardcoded values

This way to recompile Triton in higher standard, one can simply specify -DTRITON_MIN_CXX_STANDARD=20 option for cmake command, as shown above.

Related PRs:

Backends:

Note:
tensorrt_llm_backend and local_cache are already have c++17 standard, redis cache has c++20 standard specified, so these repos can be updated separately

@oandreeva-nv oandreeva-nv force-pushed the oandreeva_upgrade_cxx_standard_17 branch from d0d2b2e to c377b31 Compare January 10, 2024 02:24
@oandreeva-nv oandreeva-nv merged commit 0e278c1 into main Jan 11, 2024
3 checks passed
@oandreeva-nv oandreeva-nv deleted the oandreeva_upgrade_cxx_standard_17 branch January 11, 2024 20:05
oandreeva-nv added a commit that referenced this pull request Jan 12, 2024
oandreeva-nv added a commit that referenced this pull request Jan 12, 2024
oandreeva-nv added a commit that referenced this pull request Jan 12, 2024
oandreeva-nv added a commit that referenced this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants