Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumping min required cxx standard to 17 #61

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Bumping min required cxx standard to 17 #61

merged 1 commit into from
Jan 11, 2024

Conversation

oandreeva-nv
Copy link
Contributor

@oandreeva-nv oandreeva-nv commented Dec 26, 2023 •
edited
Loading

This PR is one of the series PRs to update Triton to C++17 standard.

Introduced logic: either set TRITON_MIN_CXX_STANDARD to 17 or use cached value. Later,TRITON_MIN_CXX_STANDARD is used to set min required standard through target_compile_features.

@oandreeva-nv oandreeva-nv mentioned this pull request Dec 26, 2023
Merged
@oandreeva-nv oandreeva-nv marked this pull request as ready for review December 26, 2023 21:40
@oandreeva-nv oandreeva-nv merged commit 214b78a into main Jan 11, 2024
1 check failed
@oandreeva-nv oandreeva-nv deleted the oandreeva_upgrade_cxx_standard_17 branch January 11, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuanLuo GuanLuo GuanLuo approved these changes

@Tabrizian Tabrizian Awaiting requested review from Tabrizian

@nv-kmcgill53 nv-kmcgill53 Awaiting requested review from nv-kmcgill53

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oandreeva-nv @GuanLuo