Update NGC versions post-22.12 release #5190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Windows Dockerfile update * Modify Dockerfile.win10.min
mc-nv
requested review from
krishung5,
GuanLuo,
jbkyang-nvi,
nv-kmcgill53 and
Tabrizian
Tabrizian
reviewed
Dec 21, 2022
| @@ -89,7 +89,7 @@ properties: | |||
| modelRepositoryPath: | |||
| type: string | |||
| title: Bucket where models are stored. Please make sure the user/service account to create the GKE app has permission to this GCS bucket. Read Triton documentation on configs and formatting details, supporting TensorRT, TensorFlow, Pytorch, Onnx ... etc. | |||
| default: gs://triton_sample_models/22_11 | |||
| default: gs://triton_sample_models/22_12 | |||
There was a problem hiding this comment.
Does this bucket exist on GCS?
There was a problem hiding this comment.
Most likely not, but this value is part of the schema validation, and user always can use values.yaml to override values accordingly.
Reason of changing it that if customer keep reuse same directory to store models samples he will start seeing incompatible state if that volume is shared among cluster.
Tabrizian
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.