-
Notifications
You must be signed in to change notification settings - Fork 170
Python Backend Windows Support #294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stub launcher changes
…unch() differentiation
… stub, pb_util include reduction
…verted stub pid function
rmccorm4
reviewed
Feb 1, 2024
Tabrizian
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @fpetrini15 !
fpetrini15
commented
Feb 6, 2024
krishung5
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal: Support base python backend functionality for Windows.
Note: This does not include support custom execution environments or GPU tensors. This base port also will not provide the full range of functionality supported in our Unix release, such as access to our model load/unload API.
Most of the code in this ticket rigidly separates Windows implementation from Unix implementation at the risk of being redundant. This is intentional as I think it will help us more quickly identify the root of any potential issues that arise, while insulating our robust Unix release. We can more tightly couple the implementations as we build our confidence with the platform.
Server changes: triton-inference-server/server#6830