Python Backend Windows Support #6830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kthui
reviewed
Feb 1, 2024
krishung5
reviewed
Feb 1, 2024
kthui
previously approved these changes
Feb 2, 2024
There was a problem hiding this comment.
LGTM. Make sure to address @krishung5 comments before merging.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
krishung5
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal: Modify the test scripts in L0_backend_python to be compatible with the windows port.
Note: Tests and subtests that make use of unsupported features such as GPU tensors, custom execution environments, and the model load/unload API have been stripped out and tagged with the corresponding Jira ticket intended to re-introduce them.
The bulk of these changes surround installing dependencies within the Windows virtualenv, using the non-default
localhostclient, killing servers with our platform-agnostic functionkill_server, and stripping out tests based on whether the testing platform is Windows.PYBE changes: triton-inference-server/python_backend#294