Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to update existing schedulers #207

Merged
merged 36 commits into from
Jul 24, 2023
Merged

Add ability to update existing schedulers #207

merged 36 commits into from
Jul 24, 2023

Conversation

kthui
Copy link
Contributor

@kthui kthui commented May 22, 2023 •
edited
Loading

@kthui kthui mentioned this pull request May 22, 2023
Merged
@kthui kthui marked this pull request as ready for review May 23, 2023 19:12
tanmayv25
tanmayv25 reviewed Jun 1, 2023
View reviewed changes
src/backend_model.cc Outdated Show resolved Hide resolved
src/model_lifecycle.cc Outdated Show resolved Hide resolved
src/scheduler.h Outdated Show resolved Hide resolved
src/sequence_batch_scheduler.cc Show resolved Hide resolved
src/sequence_batch_scheduler.cc Outdated Show resolved Hide resolved
@kthui kthui force-pushed the jacky-scheduler-update branch 2 times, most recently from 092a258 to ac20979 Compare June 1, 2023 17:44
@kthui kthui force-pushed the jacky-scheduler-update branch 2 times, most recently from 24d3984 to aaf5bac Compare June 15, 2023 01:30
@kthui kthui requested review from nnshah1 and tanmayv25 June 27, 2023 02:24
tanmayv25
tanmayv25 reviewed Jun 28, 2023
View reviewed changes
src/backend_model.cc Outdated Show resolved Hide resolved
tanmayv25
tanmayv25 reviewed Jun 28, 2023
View reviewed changes
src/backend_model.cc Outdated Show resolved Hide resolved
@tanmayv25
Copy link
Contributor

Some couple of minor changes. I will defer to @nnshah1 and @GuanLuo for final approvals.

@kthui kthui requested a review from tanmayv25 June 28, 2023 22:08
GuanLuo
GuanLuo reviewed Jun 30, 2023
View reviewed changes
src/backend_model.cc Outdated Show resolved Hide resolved
src/backend_model.cc Outdated Show resolved Hide resolved
src/sequence_batch_scheduler.cc Outdated Show resolved Hide resolved
src/sequence_batch_scheduler.cc Outdated Show resolved Hide resolved
src/sequence_batch_scheduler.cc Outdated Show resolved Hide resolved
src/sequence_batch_scheduler.cc Outdated Show resolved Hide resolved
@kthui kthui requested review from GuanLuo and nnshah1 July 11, 2023 04:02
GuanLuo
GuanLuo reviewed Jul 12, 2023
View reviewed changes
src/backend_model.cc Outdated Show resolved Hide resolved
src/backend_model.cc Show resolved Hide resolved
src/backend_model.cc Outdated Show resolved Hide resolved
src/backend_model_instance.h Show resolved Hide resolved
src/sequence_batch_scheduler.cc Outdated Show resolved Hide resolved
@kthui kthui requested a review from rmccorm4 July 19, 2023 03:32
GuanLuo
GuanLuo reviewed Jul 19, 2023
View reviewed changes
Copy link
Contributor

@GuanLuo GuanLuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please check with @tanmayv25 @rmccorm4 for their feedback

@kthui @rmccorm4
Minor comment improvement
20ca4bb 
Co-authored-by: Ryan McCormick <rmccormick@nvidia.com>
rmccorm4
rmccorm4 reviewed Jul 20, 2023
View reviewed changes
Copy link
Contributor

@rmccorm4 rmccorm4 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactoring and additions! 🚀

Only minor comments.

@kthui kthui requested a review from rmccorm4 July 20, 2023 02:31
@kthui kthui requested a review from rmccorm4 July 20, 2023 22:58
rmccorm4
rmccorm4 approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@rmccorm4 rmccorm4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please share a final clean CI run before merging.

@kthui kthui requested a review from GuanLuo July 20, 2023 23:22
@rmccorm4 rmccorm4 mentioned this pull request Jul 21, 2023
Merged
@kthui kthui merged commit ec5035c into main Jul 24, 2023
@kthui kthui deleted the jacky-scheduler-update branch July 24, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmccorm4 rmccorm4 rmccorm4 approved these changes

@tanmayv25 tanmayv25 Awaiting requested review from tanmayv25

@nnshah1 nnshah1 Awaiting requested review from nnshah1

@GuanLuo GuanLuo Awaiting requested review from GuanLuo

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kthui @tanmayv25 @nnshah1 @rmccorm4 @GuanLuo