Add more descriptions and improve function naming

triton-inference-server · Jul 13, 2023 · 686ebc9 · 686ebc9
1 parent 60993a0
commit 686ebc9
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/src/backend_model.cc b/src/backend_model.cc
@@ -406,6 +406,9 @@ TritonModel::PrepareInstances(
       std::vector<std::shared_ptr<TritonModelInstance>>>
       existing_instances = IndexInstances();
 
+  // Iterates over all the requested instances on the model config, and decides
+  // if each requested instance can reuse an existing instance or a new instance
+  // is needed.
   for (const auto& group : model_config.instance_group()) {
     std::vector<std::string> profile_names;
     for (const auto& profile_name : group.profile()) {
@@ -668,7 +671,9 @@ TritonModel::UpdateConfiguredScheduler(
     return sched->Update(added_instances, removed_instances);
   }
 
-  // Non-sequence scheduler does not need to be updated.
+  // Non-sequence scheduler does not need to be updated, because other
+  // schedulers do not require the information on model instances to function,
+  // and only interact with the rate limiter.
   return Status::Success;
 }
 

diff --git a/src/backend_model_instance.cc b/src/backend_model_instance.cc
@@ -205,7 +205,7 @@ TritonModelInstance::CreateInstance(
   }
 
   RETURN_IF_ERROR(SetNumaConfigOnThread(*host_policy));
-  auto err = CreateInstance(
+  auto err = ConstructAndInitializeInstance(
       model, name, signature, kind, device_id, profile_names, passive,
       host_policy_name, *host_policy, rate_limiter_config, secondary_devices,
       triton_model_instance);
@@ -241,7 +241,7 @@ TritonModelInstance::CreateInstance(
 }
 
 Status
-TritonModelInstance::CreateInstance(
+TritonModelInstance::ConstructAndInitializeInstance(
     TritonModel* model, const std::string& name, const Signature& signature,
     const TRITONSERVER_InstanceGroupKind kind, const int32_t device_id,
     const std::vector<std::string>& profile_names, const bool passive,

diff --git a/src/backend_model_instance.h b/src/backend_model_instance.h
@@ -206,7 +206,7 @@ class TritonModelInstance {
       const triton::common::HostPolicyCmdlineConfig& host_policy,
       const TritonServerMessage& host_policy_message,
       const std::vector<SecondaryDevice>& secondary_devices);
-  static Status CreateInstance(
+  static Status ConstructAndInitializeInstance(
       TritonModel* model, const std::string& name, const Signature& signature,
       const TRITONSERVER_InstanceGroupKind kind, const int32_t device_id,
       const std::vector<std::string>& profile_names, const bool passive,