WIP: Page extends RowBlock #23768
Draft
WIP: Page extends RowBlock #23768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
hudi
|
I didn't think of that. Actually makes a lot of sense! |
|
@dain I was going through this PR and pushed a couple of fixups that should resolve remaining failures |
dain
force-pushed
the
page-exetends-row-block
branch
from
0ca24c3 to
9646cdb
Compare
I didn't think of it easier. @martint was complaining about the differences in a chat, and I was like "we can change this now" :D |
wendigo
force-pushed
the
page-exetends-row-block
branch
from
9646cdb to
f55f61b
Compare
|
It seems that this is now good to go (except for a failing |
wendigo
reviewed
Oct 14, 2024
| exports io.trino.spi.statistics; | ||
| exports io.trino.spi.transaction; | ||
| exports io.trino.spi.type; | ||
| } |
wendigo
force-pushed
the
page-exetends-row-block
branch
from
f55f61b to
8f725e0
Compare
dain
force-pushed
the
page-exetends-row-block
branch
from
8f725e0 to
c7a6348
Compare
dain
force-pushed
the
page-exetends-row-block
branch
from
c7a6348 to
7ed50e2
Compare
|
@dain can you rebase this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the first step in replacing
PagewithRowBlockin Trino. Now that RowBlock is not null-suppressed, the difference betweenPageandRowBlockare minimal. The remaining main difference is the thatgetPositionsmethod of aPagewraps each row in a dictionary, whereasRowBlockjust wraps the entireRowBlockwith a dictionary.Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(X) Release notes are required, with the following suggested text: