Change RowBlock getSizeInBytes to not include nulls array when missing

trinodb · Oct 14, 2024 · 7ed50e2 · 7ed50e2
1 parent 9a18afd
commit 7ed50e2
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/core/trino-spi/src/main/java/io/trino/spi/block/RowBlock.java b/core/trino-spi/src/main/java/io/trino/spi/block/RowBlock.java
@@ -198,10 +198,7 @@ public long getSizeInBytes()
             return sizeInBytes;
         }
 
-        sizeInBytes = 0;
-        if (rowIsNull != null) {
-            sizeInBytes += Byte.BYTES * (long) positionCount;
-        }
+        sizeInBytes = rowIsNull == null ? 0 : Byte.BYTES * (long) positionCount;
 
         boolean hasUnloadedBlocks = false;
         for (Block fieldBlock : fieldBlocks) {
@@ -393,7 +390,7 @@ public long getRegionSizeInBytes(int position, int length)
     {
         checkValidRegion(positionCount, position, length);
 
-        long regionSizeInBytes = Byte.BYTES * (long) length;
+        long regionSizeInBytes = rowIsNull == null ? 0 : Byte.BYTES * (long) length;
         for (Block fieldBlock : fieldBlocks) {
             regionSizeInBytes += fieldBlock.getRegionSizeInBytes(position, length);
         }
@@ -415,7 +412,7 @@ public long getPositionsSizeInBytes(boolean[] positions, int selectedRowPosition
             return fixedSizePerRow * (long) selectedRowPositions;
         }
 
-        long sizeInBytes = Byte.BYTES * (long) selectedRowPositions;
+        long sizeInBytes = rowIsNull == null ? 0 : Byte.BYTES * (long) selectedRowPositions;
         for (Block fieldBlock : fieldBlocks) {
             sizeInBytes += fieldBlock.getPositionsSizeInBytes(positions, selectedRowPositions);
         }