Mitigate testDynamicFiltering* flakiness 2 #18468
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssheikin
force-pushed
the
ssheikin/38/trino/flaky_testDynamicFiltering_2
branch
from
fec9e86 to
30ff958
Compare
testDynamicFiltering* reuses global QueryTracker state which can
pruneExpiredQueries()
BaseJdbcConnectorTest is huge. Test methods are executed in parallel.
There could be more than `query.max-history` queries between
`executeWithQueryId` and `SqlQueryManager.getFullQueryInfo` invocations.
Executing `testDynamicFiltering*` methods even in almost single threaded
environment (executing these methods after all other in the test class)
eliminates this issue.
```
private static final int LAST = 1000;
@test(priority = LAST)
```
Retrying assertions mitigates this issue as well.
So adding @flaky to make CI even more solid.
ssheikin
force-pushed
the
ssheikin/38/trino/flaky_testDynamicFiltering_2
branch
from
30ff958 to
e5f63bd
Compare
|
Closing this PR in favour of #18323 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testDynamicFiltering* reuses global QueryTracker state which can pruneExpiredQueries()
BaseJdbcConnectorTest is huge. Test methods are executed in parallel. There could be more than
query.max-historyqueries betweenexecuteWithQueryIdandSqlQueryManager.getFullQueryInfoinvocations.Executing
testDynamicFiltering*methods even in almost single threaded environment (executing these methods after all other in the test class) eliminates this issue.Retrying assertions mitigates this issue as well.
So adding @flaky to make CI even more solid.
Description
This is an alternative to #18323
Additional context and related issues
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: