Skip to content

Conversation

@hashhar
Copy link
Member

@hashhar hashhar commented Mar 29, 2022

It's possible for users to switch between experimental Python types and
the old types on the fly and is not something they will decide when
installing the module. So the module must include pytz as a required
dependency.

Fixes #165

It's possible for users to switch between experimental Python types and
the old types on the fly and is not something they will decide when
installing the module. So the module must include pytz as a required
dependency.
@cla-bot cla-bot bot added the cla-signed label Mar 29, 2022
@hashhar hashhar requested review from ebyhr and mdesmet March 29, 2022 14:33
@hashhar
Copy link
Member Author

hashhar commented Mar 29, 2022

Verified as

$ pip install 'git+https://github.com/hashhar/trino-python-client.git@f51eac3bbbe8422b03d80e9b2fc05985e991f3b6'
Collecting git+https://github.com/hashhar/trino-python-client.git@f51eac3bbbe8422b03d80e9b2fc05985e991f3b6
  Cloning https://github.com/hashhar/trino-python-client.git (to revision f51eac3bbbe8422b03d80e9b2fc05985e991f3b6) to /private/var/folders/6r/mg5_6b2d7_x47lv3kc5l5xkm0000gn/T/pip-req-build-w054uvsx
  Running command git clone --filter=blob:none -q https://github.com/hashhar/trino-python-client.git /private/var/folders/6r/mg5_6b2d7_x47lv3kc5l5xkm0000gn/T/pip-req-build-w054uvsx
  Running command git rev-parse -q --verify 'sha^f51eac3bbbe8422b03d80e9b2fc05985e991f3b6'
  Running command git fetch -q https://github.com/hashhar/trino-python-client.git f51eac3bbbe8422b03d80e9b2fc05985e991f3b6
  Running command git checkout -q f51eac3bbbe8422b03d80e9b2fc05985e991f3b6
  Resolved https://github.com/hashhar/trino-python-client.git to commit f51eac3bbbe8422b03d80e9b2fc05985e991f3b6
  Preparing metadata (setup.py) ... done
Collecting pytz
  Using cached pytz-2022.1-py2.py3-none-any.whl (503 kB)
Collecting requests
  Using cached requests-2.27.1-py2.py3-none-any.whl (63 kB)
Collecting certifi>=2017.4.17
  Using cached certifi-2021.10.8-py2.py3-none-any.whl (149 kB)
Collecting charset-normalizer~=2.0.0
  Using cached charset_normalizer-2.0.12-py3-none-any.whl (39 kB)
Collecting urllib3<1.27,>=1.21.1
  Using cached urllib3-1.26.9-py2.py3-none-any.whl (138 kB)
Collecting idna<4,>=2.5
  Using cached idna-3.3-py3-none-any.whl (61 kB)
Using legacy 'setup.py install' for trino, since package 'wheel' is not installed.
Installing collected packages: urllib3, idna, charset-normalizer, certifi, requests, pytz, trino
    Running setup.py install for trino ... done
Successfully installed certifi-2021.10.8 charset-normalizer-2.0.12 idna-3.3 pytz-2022.1 requests-2.27.1 trino-0.311.0 urllib3-1.26.9

@hashhar
Copy link
Member Author

hashhar commented Mar 29, 2022

I'm adding some integration tests (for this as well as sqlalchemy) as follow-up in https://github.com/hashhar/trino-python-client/tree/hashhar/dist-sqlalchemy to avoid such in future.

@hashhar hashhar merged commit 0c14827 into trinodb:master Mar 29, 2022
@hashhar hashhar deleted the hashhar/fix-pytz-missing branch March 29, 2022 14:51
@ebyhr
Copy link
Member

ebyhr commented Mar 29, 2022

@hashhar @aksakalli Thanks for fixing the instalation issue. Going to release a new version. cc: @findepi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

ModuleNotFoundError: No module named 'pytz'

3 participants