Fix pytz module not found error

[aksakalli]

Fixing #165 issue.

[cla-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

[cla-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

[hashhar]

I'd have expected that the setup.py would have ensured that pytz gets installed as a dependency?

[aksakalli]

I'd have expected that the setup.py would have ensured that pytz gets installed as a dependency?

I thought the intention of #160 is to depend on pytz only when experimental_python_types=True.

[cla-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

[aksakalli]

I'd have expected that the setup.py would have ensured that pytz gets installed as a dependency?

I created an alternative PR #167

[aksakalli]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

I sent the signed CLA.

[hashhar]

This seems like the better solution to me.

However you'd still want to add an entry to "extras_require" to setup.py for experimental types support so that pytz gets installed automatically.

The reason why pytz doesn't get installed by default is because install_requires in setup.py only lists requests.

mistakenly approved - ci is red

[hashhar]

On second thought, the API allows people to switch between normal and python types on the fly. So ideally pytz must be a required dependency otherwise the code may fail at runtime depending on how the cursor is created.

I've implemented that in #168

[hashhar]

Alternative solution implemented in #168.